[GSoC 2026] Kafka Streams runner: shorten comments, and fix the license header and Python formatting - #39781
Merged
je-ik merged 2 commits intoAug 17, 2026
Conversation
…g for master CI The measurement docker-compose file had no Apache license header, which RAT rejects, and one line in the Python wrapper was not as yapf formats it. Neither ran on the feature branch, whose CI only built the runner.
Several class comments explained more than they needed to, which makes them less likely to be read rather than more. Shortened the longest, keeping the reasoning and dropping the retelling. Also corrects four that had gone stale: two translators claiming topics are not created automatically, the payload claiming its serde does not exist yet, and the read translator pointing at the test runner for a conversion the runner now does itself.
je-ik
merged commit Aug 17, 2026
8d5f651
into
apache:feat/18479-kafka-streams-runner-skeleton
3 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #18479. The changes that were sitting on the master merge, moved onto the feature branch so the merge to master can come from the branch itself.
Two of them are CI fixes the feature branch never exercised, because its own workflow only built the runner. RAT rejects the measurement
docker-compose.ymlfor having no Apache license header, and yapf wants one line in the Python wrapper joined.The rest is shortening the explanation comments. Measured against the other runners, comment lines as a fraction of code were 33% here against 17% for core-java, 14% for Spark, 12% for direct-java and 9% for Flink, and long blocks were about three times as frequent per file as the worst of those. This takes it to 29% and cuts the longest block from 52 lines to 36; the worst class comments are rewritten and the reasoning kept.
It also corrects four comments that had gone stale: two translators claiming topics are not created automatically, though
KafkaStreamsTopicManagerhas created them for months;KStreamsPayloadsaying its serde does not exist yet; andReadTranslatorpointing at the test runner for a conversion the runner now does itself.Verified with
./gradlew -Pwith-kafka-streams-runner :runners:kafka-streams:build.