Split Precommit Integration Tests into a separate Build#4023
Split Precommit Integration Tests into a separate Build#4023tgroh wants to merge 2 commits intoapache:masterfrom
Conversation
Integration tests consume a significant amount of time, and are easily separable from the remaining tests.
|
For your consideration. |
| common_job_properties.setPreCommit(delegate, 'mvn failsafe:integration-test -pl examples/java -am', 'Run Java Integration PreCommit') | ||
|
|
||
| // Maven goals for this job: The Java Examples and their dependencies | ||
| goals('''\ |
There was a problem hiding this comment.
Jason made the good point that if you build an array of args and then join them on spaces, you avoid the possibility of omitting a backslash, which I have done in ~every one of my changes. Yours looks good already though :-)
| clean \ | ||
| compile \ | ||
| test-compile \ | ||
| failsafe:integration-test \ |
There was a problem hiding this comment.
Notably, invoking integration-test will neglect the cleanup (I don't know if we have any). I think if you add post-integration-test you are OK, but maybe just raw verify?
It is covered pretty early here: http://maven.apache.org/surefire/maven-failsafe-plugin/
| --batch-mode \ | ||
| --errors \ | ||
| --activate-profiles release,jenkins-precommit,direct-runner,dataflow-runner,spark-runner,flink-runner,apex-runner \ | ||
| --activate-profiles release,direct-runner,dataflow-runner,spark-runner,flink-runner,apex-runner \ |
There was a problem hiding this comment.
These profiles are only for the examples to run against different runners. I think there should be either none or just direct-runner.
|
Do we still need this? |
|
I don't think it's currently high-priority. Closing. |
3 participants
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Integration tests consume a significant amount of time, and are easily
separable from the remaining tests.