[BEAM-3139] Update dataflow.version on the beam root pom.xml#4076
Merged
asfgit merged 1 commit intoapache:masterfrom Nov 7, 2017
Merged
[BEAM-3139] Update dataflow.version on the beam root pom.xml#4076asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
Author
|
R: @kennknowles |
Author
|
retest this please |
Member
|
run Dataflow ValidatesRunner |
Member
|
LGTM |
Member
|
Can you squash the commits to make it really easy for me to merge it? |
debd73f to
9e5f641
Compare
Author
|
Done, is that the proper way to squash them? |
Member
|
Looks good to me. Any set of commits is OK as long as they are each something that makes sense on their own, and is legible in the history. Also, pragmatically, the easiest unit of rollback in addition to the atomic unit of history/blame. |
asfgit
pushed a commit
that referenced
this pull request
Nov 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Update dataflow.version on the beam root pom.xml to v1b3-rev218-1.22.0