Skip to content

[BEAM-3139] Update dataflow.version on the beam root pom.xml#4076

Merged
asfgit merged 1 commit intoapache:masterfrom
ajamato:ajamato_dataflow_version
Nov 7, 2017
Merged

[BEAM-3139] Update dataflow.version on the beam root pom.xml#4076
asfgit merged 1 commit intoapache:masterfrom
ajamato:ajamato_dataflow_version

Conversation

@ajamato
Copy link

@ajamato ajamato commented Nov 4, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Update dataflow.version on the beam root pom.xml to v1b3-rev218-1.22.0

@ajamato ajamato changed the title Ajamato dataflow version [BEAM-3139] Update dataflow.version on the beam root pom.xml Nov 4, 2017
@ajamato
Copy link
Author

ajamato commented Nov 6, 2017

R: @kennknowles

@ajamato
Copy link
Author

ajamato commented Nov 6, 2017

retest this please

@kennknowles
Copy link
Member

run Dataflow ValidatesRunner

@kennknowles
Copy link
Member

LGTM

@kennknowles
Copy link
Member

Can you squash the commits to make it really easy for me to merge it?

@ajamato ajamato force-pushed the ajamato_dataflow_version branch from debd73f to 9e5f641 Compare November 6, 2017 23:21
@ajamato
Copy link
Author

ajamato commented Nov 6, 2017

Done, is that the proper way to squash them?

@kennknowles
Copy link
Member

Looks good to me. Any set of commits is OK as long as they are each something that makes sense on their own, and is legible in the history. Also, pragmatically, the easiest unit of rollback in addition to the atomic unit of history/blame.

@asfgit asfgit merged commit 9e5f641 into apache:master Nov 7, 2017
asfgit pushed a commit that referenced this pull request Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants