[BEAM-2963] Stage the portable pipeline; put URL in pipeline options#4089
Conversation
|
R: @lukecwik Same story, new place to put the info. |
8356123 to
6c1ebdb
Compare
|
To my knowledge, arbitrary pipeline options don't make it to the runner harness. |
|
The metadata field is a Map. That wouldn't typecheck. |
|
You mean hacking it with a custom jackson hook? I'd rather not mess with that, since pipelineoptions is already a pretty arbitrary bag and actually sort of better than VM metadata for this kind of data. |
|
Arbitrary pipeline options still don't make it to the runner harness. |
|
@herohde can you comment on this? I think that we have adequate control to get this info to the right place noninvasively. |
|
Pipeline options are available to the runner harness in Dataflow, so this approach would work fine. It's trivial to make the runner harness grab what it needs here. |
|
LGTM |
1 similar comment
|
LGTM |
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.