[BEAM-3482] fix serialization error in BigQueryIO's DynamicDestinations - #4417
Merged
Conversation
Contributor
|
Hmm this object is not supposed to be serialized. This PR will make it simply deserialize as null, and I'm highly doubtful that the code will work correctly after that. Could you post a more complete deserialization error by running with |
Contributor
Author
|
Hi Eugene,
I'm busy with something else and will not be able to test anytime soon. The
code I modified, I only copied from FileBasedSink.DynamicDestinations - it
appeared to be the same code (except not updated with transient modifier)
for BQIO.DynamicDestinations. It would seem someone faced similar issue
with FileBasedSink and made the changes there, but I'm not familiar enough
with beam to comment on whether it should be Serialized or not.
Regards,
Shashank
…On Wed, Jan 17, 2018 at 3:40 AM, Eugene Kirpichov ***@***.***> wrote:
Hmm this object is not supposed to be serialized. This PR will make it
simply deserialize as null, and I'm highly doubtful that the code will work
correctly after that. Could you post a more complete deserialization error
by running with -Dsun.io.serialization.extendedDebugInfo=true ? I wonder
if Apex runner is serializing something unnecessarily.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4417 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AI0klEPu-xANm7iIqkuiDyMxQsmsjkdaks5tLR4_gaJpZM4Rfm3l>
.
|
Contributor
|
Hmm, okay, simpler question: did your pipeline start working correctly after this change? :) |
Contributor
Author
|
Yes it did.
…On 18 Jan 2018 3:46 am, "Eugene Kirpichov" ***@***.***> wrote:
Hmm, okay, simpler question: did your pipeline start working correctly
after this change? :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4417 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AI0klMAoVtaQnTTK6UYh--g0l26eyb4Sks5tLnFTgaJpZM4Rfm3l>
.
|
Contributor
|
It would help if you could provide a code snippet that doesn't work without this. |
Contributor
|
I'm going to merge this because it seems to help for Apex runner and is harmless otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.