Fix errorprone warning

[akedin]

Errorprone detects catching throwable and warns that it hides assertions failures

---

Follow this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
• Write a pull request description that is detailed enough to understand:
  • What the pull request does
  • Why it does it
  • How it does it
  • Why this approach
• Each commit in the pull request should have a meaningful subject line and body.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

[akedin]

R: @tgroh @lostluck

[tgroh]

This looks like the actual bug, rather than a spurious warning - the AssertionError thrown by fail can't ever be propagated out of the catch. You should instead fix the bug.

http://errorprone.info/bugpattern/TryFailThrowable

[akedin]

makes sense, will do

[akedin]

fixed

[tgroh]

It would appear that we have some bugs in our tester, or in our resolvers:

java.lang.AssertionError: Should not be able to resolve against file resource hdfs:/file
	at org.junit.Assert.fail(Assert.java:88)
	at org.apache.beam.sdk.io.fs.ResourceIdTester.validateFailureResolvingIds(ResourceIdTester.java:118)
	at org.apache.beam.sdk.io.fs.ResourceIdTester.runResourceIdBattery(ResourceIdTester.java:58)
	at org.apache.beam.sdk.io.hdfs.HadoopResourceIdTest.testResourceIdTester(HadoopResourceIdTest.java:69)

[kennknowles]

run java precommit

[kennknowles]

Just waiting for green from our new and glorious :javaPreCommit

[akedin]

The failure is an actual bug. This PR allows the assertion to fail the test. Now we have to actually fix it

[akedin]

closing this for now