-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-3966] Move sdks/java/fn-execution to util/java/fn-execution
#4974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @tgroh |
|
LGTM; R: @kennknowles as I know you also dislike 'util' as a name, but it seems reasonable here (but I would be very happy if you have better ideas) |
|
Can we defer doing moves/renames like this till we are further along? This will cause a bunch of pain for people integrating back changes on hacking branches. |
|
LGTM. True that I generally dislike In this case, having a bucket for "everything not SDK or runner" seems useful, so I'm fine with it. |
|
Looks like about 27 days of conflicts there. Can you rebase? |
|
It might be helpful to coordinate with a committer on Slack just to time this. Since the move is approved, you could just re-automatically-do-it and get it in within a couple minutes. |
|
OK. I though it was still contentious, but if things look good as they are, I'll rebase and ping someone when it's ready for merging. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
We have turned on autoformatting of the codebase, which causes small conflicts across the board. You can probably safely rebase and just keep your changes. Like this: Please ping me if you run into any difficulty. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This also renames the Java package itself to match the new module name.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.