Skip to content

Conversation

@bsidhom
Copy link
Contributor

@bsidhom bsidhom commented Mar 28, 2018

This also renames the Java package itself to match the new module name.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@bsidhom
Copy link
Contributor Author

bsidhom commented Mar 28, 2018

R: @tgroh

@tgroh
Copy link
Member

tgroh commented Mar 28, 2018

LGTM; R: @kennknowles as I know you also dislike 'util' as a name, but it seems reasonable here (but I would be very happy if you have better ideas)

@tgroh tgroh requested a review from kennknowles March 28, 2018 22:22
@lukecwik
Copy link
Member

Can we defer doing moves/renames like this till we are further along?

This will cause a bunch of pain for people integrating back changes on hacking branches.

@kennknowles
Copy link
Member

LGTM.

True that I generally dislike util as a name because it is extremely unspecific / meaningless and usually ends up containing ~everything. The Java libraries are a good example. If you went with everything it would make it clear that the prefix is not useful. I often go with misc to indicate that things that are not misc should gradually move out once they have a real theme.

In this case, having a bucket for "everything not SDK or runner" seems useful, so I'm fine with it.

@kennknowles
Copy link
Member

Looks like about 27 days of conflicts there. Can you rebase?

@kennknowles
Copy link
Member

It might be helpful to coordinate with a committer on Slack just to time this. Since the move is approved, you could just re-automatically-do-it and get it in within a couple minutes.

@kennknowles kennknowles removed their request for review April 24, 2018 22:16
@bsidhom
Copy link
Contributor Author

bsidhom commented Apr 24, 2018

OK. I though it was still contentious, but if things look good as they are, I'll rebase and ping someone when it's ready for merging.

@stale
Copy link

stale bot commented Jun 23, 2018

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 23, 2018
@kennknowles
Copy link
Member

We have turned on autoformatting of the codebase, which causes small conflicts across the board. You can probably safely rebase and just keep your changes. Like this:

$ git rebase
... see some conflicts
$ git diff
... confirmed that the conflicts are just autoformatting
... so we can just keep our changes are do our own autoformat
$ git checkout --theirs --
$ git add -u
$ git rebase --continue
$ ./gradlew spotlessJavaApply

Please ping me if you run into any difficulty.

@stale
Copy link

stale bot commented Aug 27, 2018

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Aug 27, 2018
@stale
Copy link

stale bot commented Sep 3, 2018

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants