[BEAM-3995] Build self-contained Nexmark jar#5026
Closed
kennknowles wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-3995] Build self-contained Nexmark jar#5026kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
It is a big hammer; too big. We'll actually need to have a way to get the different runners on the classpath without bundling. But Gradle has nothing that I would care to use equivalent to |
Member
Author
|
Ah, I think this is really not going to be workable. String munging to plumb cmdline args may still be what we need to do, in 2018. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To run the Nexmark benchmarks, we will separate the build from the run step. The build step is owned by Gradle, while the run step is simply running a program. Nexmark is already designed this way.
WIP: the expected full set of dependencies is not contained in the shadow jar. I don't know why this is yet, but expect it has to do with how we manage the base setup. TBD.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.