Skip to content

[BEAM-3995] Build self-contained Nexmark jar#5026

Closed
kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles:nexmark-gradle
Closed

[BEAM-3995] Build self-contained Nexmark jar#5026
kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles:nexmark-gradle

Conversation

@kennknowles
Copy link
Member

@kennknowles kennknowles commented Apr 4, 2018

To run the Nexmark benchmarks, we will separate the build from the run step. The build step is owned by Gradle, while the run step is simply running a program. Nexmark is already designed this way.

WIP: the expected full set of dependencies is not contained in the shadow jar. I don't know why this is yet, but expect it has to do with how we manage the base setup. TBD.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@kennknowles
Copy link
Member Author

It is a big hammer; too big. We'll actually need to have a way to get the different runners on the classpath without bundling. But Gradle has nothing that I would care to use equivalent to mvn exec:java. Still poking around but the solutions I've found are not reasonable.

@kennknowles
Copy link
Member Author

Ah, I think this is really not going to be workable. String munging to plumb cmdline args may still be what we need to do, in 2018.

@kennknowles kennknowles closed this Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant