Skip to content

Suppress some (fatal) warnings in schemas. #5122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertwb merged 1 commit into from
Apr 19, 2018
Merged

Suppress some (fatal) warnings in schemas. #5122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ public abstract static class FieldType implements Serializable {
/**
* Returns optional extra metadata.
*/
@SuppressWarnings("mutable")
@Nullable public abstract byte[] getMetadata();
abstract FieldType.Builder toBuilder();
@AutoValue.Builder
Expand Down
4 changes: 4 additions & 0 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,10 @@ private Object verifyPrimitiveType(Object value, TypeName type, String fieldName
return value;
}
break;
default:
// Shouldn't actually get here, but we need this case to satisfy linters.
throw new IllegalArgumentException(
String.format("Not a primitive type for field name %s: %s", fieldName, type));
}
throw new IllegalArgumentException(
String.format("For field name %s and type %s found incorrect class type %s",
Expand Down