Skip to content

Suppress some (fatal) warnings in schemas.#5122

Merged
robertwb merged 1 commit intoapache:masterfrom
robertwb:schema-fixes
Apr 19, 2018
Merged

Suppress some (fatal) warnings in schemas.#5122
robertwb merged 1 commit intoapache:masterfrom
robertwb:schema-fixes

Conversation

@robertwb
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@robertwb robertwb requested a review from kennknowles April 13, 2018 00:47
@robertwb
Copy link
Contributor Author

@kennknowles Ping? Was this subsumed by another PR?

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this looks good. I hadn't had a chance to see what was suppressed. There's definitely a world in which we have the same functionality with no warnings and no suppressions, so I wanted to get that recorded in the cleanup JIRAs.

@robertwb
Copy link
Contributor Author

Thanks.

@robertwb robertwb merged commit dffe509 into apache:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants