Skip to content

[BEAM-4229] Revert BigQuery SQL support so Spanner works#5286

Merged
chamikaramj merged 2 commits intoapache:masterfrom
apilloud:revert
May 5, 2018
Merged

[BEAM-4229] Revert BigQuery SQL support so Spanner works#5286
chamikaramj merged 2 commits intoapache:masterfrom
apilloud:revert

Conversation

@apilloud
Copy link
Copy Markdown
Member

@apilloud apilloud commented May 5, 2018 •
edited
Loading

So I can't downgrade BigQuery because of google-api-client, I can't upgrade Spanner because of grpc, and I can't have both because of google-cloud-core.

Time to revert my feature.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

apilloud added 2 commits May 4, 2018 21:19
@apilloud
Revert "Merge pull request apache#5220: [BEAM-3983][SQL] Add BigQuery…
8447b53 
… table provider"

This reverts commit 1ea4db6, reversing
changes made to ddf7353.
@apilloud
Revert "Merge pull request apache#4947: [BEAM-3983] Add utils for con…
343d071 
…verting to BigQuery types"

This reverts commit 2bcc606, reversing
changes made to b7bfca9.
@apilloud
Copy link
Copy Markdown
Member Author

apilloud commented May 5, 2018

R: @chamikaramj
cc: @kennknowles

@chamikaramj
Copy link
Copy Markdown
Contributor

chamikaramj commented May 5, 2018

Thanks. LGTM.

@chamikaramj chamikaramj merged commit 0e1dccc into apache:master May 5, 2018
@kennknowles
Copy link
Copy Markdown
Member

kennknowles commented May 6, 2018

Reading the description of this PR makes me sad. Is there a JIRA filed for the followup? We need at least a workaround.

@chamikaramj
Copy link
Copy Markdown
Contributor

chamikaramj commented May 7, 2018 •
edited
Loading

Probably best path forward is to update gRPC and protobuf dependencies which was requested by a number of users.

@kennknowles
Copy link
Copy Markdown
Member

kennknowles commented May 7, 2018

Do we have to update them globally? Is there a JIRA with any notes on which modules have which problems?

@chamikaramj
Copy link
Copy Markdown
Contributor

chamikaramj commented May 7, 2018

I think updating globally is safer. For example, DataflowRunner might run into an incorrect state if a gRPC jar pulled in from a module is added to the classpath along with the version shaded internally.

@apilloud
Copy link
Copy Markdown
Member Author

apilloud commented May 7, 2018

https://issues.apache.org/jira/browse/BEAM-3098

apilloud added a commit to apilloud/beam that referenced this pull request May 7, 2018
@apilloud
Revert "Merge pull request apache#5286: [BEAM-4229] Revert BigQuery S…
2cdacab 
…QL support so Spanner works"

This reverts commit 0e1dccc, reversing
changes made to 21e11f2.
apilloud added a commit to apilloud/beam that referenced this pull request May 8, 2018
@apilloud
Revert "Merge pull request apache#5286: [BEAM-4229] Revert BigQuery S…
e689ee8 
…QL support so Spanner works"

This reverts commit 0e1dccc, reversing
changes made to 21e11f2.
@apilloud apilloud mentioned this pull request Nov 7, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apilloud @chamikaramj @kennknowles