Skip to content

[BEAM-3827] Invoke Go Dataflow integration tests from post-commit#5409

Merged
kennknowles merged 1 commit intoapache:masterfrom
herohde:integration2
May 21, 2018
Merged

[BEAM-3827] Invoke Go Dataflow integration tests from post-commit#5409
kennknowles merged 1 commit intoapache:masterfrom
herohde:integration2

Conversation

@herohde
Copy link
Contributor

@herohde herohde commented May 18, 2018

  • Add a Python ValidatesContainer-style script to build the Go container around the integration tests. It uses the same bash logic for consistency, but ideally we'd have a better solution for building containers for integration tests shared across the SDKs.
  • Add another Gradle build file to build the linux_amd64 Go integration test worker with a fixed name. This separation makes it easier to invoke the correct test driver from the script, because we don't have to figure out what the host platform and architecture is. It didn't seem possible to do this from a single Gradle build file.

Design notes: https://docs.google.com/document/d/1jy6EE7D4RjgfNV0FhD3rMsT1YKhnUfcHRZMAlC6ygXw/edit?usp=sharing

@herohde
Copy link
Contributor Author

herohde commented May 18, 2018

Run Go PostCommit

@herohde
Copy link
Contributor Author

herohde commented May 18, 2018

R: @alanmyrvold @jasonkuster

@herohde
Copy link
Contributor Author

herohde commented May 18, 2018

R: @lostluck @kennknowles

@kennknowles
Copy link
Member

LGTM

@kennknowles kennknowles merged commit d72cfc5 into apache:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants