[BEAM-4076] Remove unsafe methods from Schema.TypeName and Schema.FieldType#5498
Merged
kennknowles merged 2 commits intoapache:masterfrom May 31, 2018
Merged
[BEAM-4076] Remove unsafe methods from Schema.TypeName and Schema.FieldType#5498kennknowles merged 2 commits intoapache:masterfrom
kennknowles merged 2 commits intoapache:masterfrom
Conversation
kennknowles
force-pushed
the
no-more-type
branch
2 times, most recently
from
af84fee to
1ae3132
Compare
2 tasks
Member
Author
|
R: @akedin Last in the trilogy. |
tgroh
approved these changes
May 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods
TypeName.type()andFieldType.withMapType()etc all refer to various operations on types and type constructors that are not well-defined for a lot of inputs. Since these methods are also not needed, this PR deletes them.This is stacked on #5497
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.