[BEAM-4618] Fix errors in BeamModulePlugin perf test section#5732
Merged
kennknowles merged 1 commit intoapache:masterfrom Jun 22, 2018
Merged
[BEAM-4618] Fix errors in BeamModulePlugin perf test section#5732kennknowles merged 1 commit intoapache:masterfrom
kennknowles merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
R: @lgajowy FYI this is where the code moved, and what I had to do to make it work in Gradle plugin code. It is very slightly different, in boring ways, than the Gradle DSL. |
Member
Author
|
Run Java AvroIO Performance Test |
Member
Author
|
Run Java TextIO Performance Test HDFS |
Contributor
|
LGTM. Thanks for the fix! |
charlesccychen
pushed a commit
to charlesccychen/beam
that referenced
this pull request
Jul 24, 2018
…lugin perf test section
charlesccychen
pushed a commit
to charlesccychen/beam
that referenced
this pull request
Jul 26, 2018
…lugin perf test section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BeamModulePluginsection on perf tests was not migrated adequately frombuild_rules.gradleFollow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.