[BEAM-4365] Migrate some date expressions to operators#5743
Merged
kennknowles merged 1 commit intoapache:masterfrom Jun 25, 2018
Merged
[BEAM-4365] Migrate some date expressions to operators#5743kennknowles merged 1 commit intoapache:masterfrom
kennknowles merged 1 commit intoapache:masterfrom
Conversation
kennknowles
force-pushed
the
std-ops
branch
4 times, most recently
from
4e2dda9 to
b59e6c2
Compare
Member
Author
|
R: @apilloud more code that "should be deleted" when we hook up to RexToLix :-) |
Member
|
LGTM. |
charlesccychen
pushed a commit
to charlesccychen/beam
that referenced
this pull request
Jul 26, 2018
…ions to operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was setting out to improve coverage of date operators and focus on DSL-level tests. Discovered a couple of issues but mostly the coverage of these is OK. So the main improvement here is centralizing argument eval and reducing test bulk, plus a tiny bit better coverage.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.