[BEAM-3900] Improvements in Metrics translation, composite transforms, tests and win. API#5783
Closed
VaclavPlajt wants to merge 3718 commits intoapache:dsl-euphoriafrom
Closed
[BEAM-3900] Improvements in Metrics translation, composite transforms, tests and win. API#5783VaclavPlajt wants to merge 3718 commits intoapache:dsl-euphoriafrom
VaclavPlajt wants to merge 3718 commits intoapache:dsl-euphoriafrom
Conversation
Member
|
We have turned on autoformatting of the codebase, which causes small conflicts across the board. You can probably safely rebase and just keep your changes. Like this: Please ping me if you run into any difficulty. |
1ab7782 to
131d558
Compare
2 tasks
Contributor
Author
|
please retest this |
Contributor
|
Run Java PreCommit |
…itioning removal
…er partitioning removal, still some tests failing
…st, FilterTest enabled. Small modifications where necessary to make them work. TopPerKeyTest could not be enabled since TopPerKey is translated into unsupported ReduceStateByKey operator. WindowingTest need to be redesigned. WatermarkTest was removed.
…executor after rebase above 'dsl-euphoria'.
…utorContext` renamed to `TranslationContext`.
…sess from `euphoria-beam` moved to `...euphoria.core.translate` package.
… `ReduceByKey` operator.
All `build.gradle` files in euphoria modules adapted. Some compilation warnings removed, `@SuppressFBWarnings` removed due to licensing issues, unused utils class `OperatorTranslator` removed.
…Euphoria-core build adapted after rebase on beam/master.
…windowing removed. Minor code improvements.
…suggested in code review.
68fa362 to
69c912e
Compare
69c912e to
a34d5d3
Compare
Contributor
|
Is this PR in progress or should we close it as stale? |
Contributor
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of improvements:
R: @jbonofre
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)