[BEAM-4622] Makes required to call Beam SQL expressions validation#5912
Merged
aromanenko-dev merged 2 commits intoapache:masterfrom Jul 17, 2018
Merged
Conversation
aromanenko-dev
force-pushed
the
BEAM-4622-BeamSQL-expressions
branch
from
d5ee892 to
b7956ad
Compare
Contributor
Author
|
retest this please |
vectorijk
reviewed
Jul 10, 2018
| public boolean accept() { | ||
| // Interval types will be already converted into BIGINT after evaluation. | ||
| SqlTypeFamily opTypeFamily = opType(0).getFamily(); | ||
| if (opTypeFamily.equals(SqlTypeFamily.INTERVAL_DAY_TIME) |
Contributor
There was a problem hiding this comment.
I think it's good to add a unit test for it
Contributor
Author
There was a problem hiding this comment.
@vectorijk Actually, it's already implicitly tested by BeamSqlDslSqlStdOperatorsTest.testTimestampDiff() and it failed after I did a refactoring of BeamSqlFnExecutor and before adding this check. Do you think it will make sense to add specific test for this case?
aromanenko-dev
force-pushed
the
BEAM-4622-BeamSQL-expressions
branch
from
b7956ad to
7cf8f6c
Compare
Contributor
Author
|
@akedin Could you take a look on this? |
Contributor
|
LGTM |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
- Move docs from 'docs/firestore' into 'firestore/docs' and leave symlink. - Harmonize / DRY 'firestore/README.rst' and 'firestore/docs/index.rst'. - Remove docs for GAPIC-generated bits (they aren't part of the surface). - Ensure that docs still build from top-level. Toward apache#5912.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved huge switch statement block into separate method which returns new object of
BeamSqlExpressionand then that object callsaccept()method to perform a validation. This refactoring discovered some test failures that were fixed by fixingaccept()implementation of corresponding expressions.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)