[BEAM-3746] Change incompatible message from referencing the output collection to referencing the input collection#6632
Merged
kennknowles merged 1 commit intoapache:masterfrom Oct 16, 2018
Conversation
Contributor
Author
|
R: @kennknowles |
kennknowles
approved these changes
Oct 11, 2018
Member
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
LGTM. I'll see about kicking the tests and whatnot.
Member
|
run java precommit |
… referencing the input collection
rohdesamuel
force-pushed
the
beam-3746-fix
branch
from
f0c2578 to
fbbf0a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous error text was erroneously referencing the output collection instead of the input collection.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)