[BEAM-5176] remove preconfigured '-Xlint:deprecation' from compilerArgs#6831
Merged
kennknowles merged 1 commit intoapache:masterfrom Oct 25, 2018
Conversation
Contributor
Author
|
R: @kennknowles PTAL, as jira is assigned to you FYI: @echauchot |
kennknowles
approved these changes
Oct 25, 2018
Member
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
Thank you! I know at least a few people who have spent time on this and not gotten a solution.
Member
There was a problem hiding this comment.
I think the most useful link here might be https://youtrack.jetbrains.com/issue/IDEA-196615, but let's just interlink them and all that.
Contributor
Author
There was a problem hiding this comment.
Thinking about that, u are probably right. Should we change and force-push here?
Member
There was a problem hiding this comment.
Yes, that would be fine. As it is just a comment change I won't have to wait another hour for tests.
Member
|
I'll just let the java PreCommit run, then merge. |
adude3141
force-pushed
the
BEAM-5176-failOnWarnings-behave-differently-between-CLI-and-Intellij-build
branch
from
ff0ab3e to
24cbcca
Compare
Contributor
|
@adude3141 well done ! Thanks for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intellij adds -Xlint:deprecation as JavaCC option if run from menu. This clashes with our failOnWarnings configuration done in BeamModulePlugin
This PR removes that preconfigured option, as we do default to disabled deprecation warnings.
See also jira issue [1] and corresponding IntelliJ issue [2]
[1] https://issues.apache.org/jira/browse/BEAM-5176
[2] https://youtrack.jetbrains.com/issue/IDEA-196615
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)