[BEAM-3573] Move GCPIO test utilities to main jar#6838
[BEAM-3573] Move GCPIO test utilities to main jar#6838kennknowles merged 2 commits intoapache:masterfrom
Conversation
|
There is some hope that eliminating bad test jar deps might mitigate https://issues.apache.org/jira/browse/BEAM-5035, https://issues.apache.org/jira/browse/BEAM-5207, https://issues.apache.org/jira/browse/BEAM-5116. In any case it is the right direction so no harm in moving to find out how much it helps. |
380785d to
3921f49
Compare
|
R: @apilloud I believe you did the deepest digging on this parallel build issue. From the issues and gists, I'm not 100% certain it all comes back to this, but I'm not 100% certain it doesn't. Our other modules have test deps that can be just "test runtime" deps. But I'm pretty sure this is the only hard dependency on a class in another test jar for any transitive dep of the tasks I saw failing. |
|
I did little to no digging beyond disabling parallel tests to fix flakes. This looks like it might fix the root cause. LGTM. |
|
run java postcommit |
|
The failure in postcommit is the same from #6864. We have tests in the Dataflow worker codebase that are not thread safe. I will drop that commit, then this should be g2g. |
32897e8 to
a8546bc
Compare
|
run java postcommit |
These test utilities are used by clients to test their code. They are not isolated to the test suite jar.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)