[BEAM-5875] Add missing dependency in test-utils module#6859
Merged
kennknowles merged 1 commit intoapache:masterfrom Oct 27, 2018
Merged
[BEAM-5875] Add missing dependency in test-utils module#6859kennknowles merged 1 commit intoapache:masterfrom
kennknowles merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I'm sorry - I should have tested this more thoroughly before. I successfully ran the smoke nexmark suites locally for direct and flink (local) runners using these instructions |
Contributor
Author
|
@kennknowles could you take a look? |
2 tasks
Member
|
Cool. It would be nice to ensure this doesn't compile. I think we need Gradle's |
Member
|
This is definitely needed based on a |
lukecwik
reviewed
Oct 30, 2018
|
|
||
| dependencies { | ||
| shadow project(path: ":beam-sdks-java-core", configuration: "shadow") | ||
| shadow library.java.guava |
Member
There was a problem hiding this comment.
This should be compile scope
From
: // By default, the shadow plugin is enabled to perform shading of commonly found dependencies.
// Because of this it is important that dependencies are added to the correct configuration.
// Dependencies should fall into one of these four configurations:
// * compile - Required during compilation or runtime of the main source set.
// This configuration represents all dependencies that much also be shaded away
// otherwise the generated Maven pom will be missing this dependency.
// * shadow - Required during compilation or runtime of the main source set.
// Will become a runtime dependency of the generated Maven pom.
// * testCompile - Required during compilation or runtime of the test source set.
// This must be shaded away in the shaded test jar.
// * shadowTest - Required during compilation or runtime of the test source set.
// TODO: Figure out whether this should be a test scope dependency
// of the generated Maven pom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes nexmark suites failures.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)