Skip to content

[BEAM-5875] Add missing dependency in test-utils module#6859

Merged
kennknowles merged 1 commit intoapache:masterfrom
lgajowy:fix-nexmark-suites
Oct 27, 2018
Merged

[BEAM-5875] Add missing dependency in test-utils module#6859
kennknowles merged 1 commit intoapache:masterfrom
lgajowy:fix-nexmark-suites

Conversation

@lgajowy
Copy link
Contributor

@lgajowy lgajowy commented Oct 27, 2018

This fixes nexmark suites failures.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@lgajowy lgajowy requested a review from kennknowles October 27, 2018 10:54
@lgajowy
Copy link
Contributor Author

lgajowy commented Oct 27, 2018

I'm sorry - I should have tested this more thoroughly before. I successfully ran the smoke nexmark suites locally for direct and flink (local) runners using these instructions

@lgajowy
Copy link
Contributor Author

lgajowy commented Oct 27, 2018

@kennknowles could you take a look?

@kennknowles
Copy link
Member

Cool. It would be nice to ensure this doesn't compile. I think we need Gradle's java-library plugin for that.

@kennknowles
Copy link
Member

This is definitely needed based on a grep. So I'll merge this and assume mine is obsolete.


dependencies {
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.guava
Copy link
Member

@lukecwik lukecwik Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be compile scope

From

// * compile - Required during compilation or runtime of the main source set.
:

    // By default, the shadow plugin is enabled to perform shading of commonly found dependencies.
    // Because of this it is important that dependencies are added to the correct configuration.
    // Dependencies should fall into one of these four configurations:
    //  * compile     - Required during compilation or runtime of the main source set.
    //                  This configuration represents all dependencies that much also be shaded away
    //                  otherwise the generated Maven pom will be missing this dependency.
    //  * shadow      - Required during compilation or runtime of the main source set.
    //                  Will become a runtime dependency of the generated Maven pom.
    //  * testCompile - Required during compilation or runtime of the test source set.
    //                  This must be shaded away in the shaded test jar.
    //  * shadowTest  - Required during compilation or runtime of the test source set.
    //                  TODO: Figure out whether this should be a test scope dependency
    //                  of the generated Maven pom.

@lgajowy lgajowy deleted the fix-nexmark-suites branch May 20, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants