[BEAM-5866] Override structuralValue in ListCoder and MapCoder#6862
Merged
robertwb merged 2 commits intoapache:masterfrom Dec 10, 2018
Merged
[BEAM-5866] Override structuralValue in ListCoder and MapCoder#6862robertwb merged 2 commits intoapache:masterfrom
robertwb merged 2 commits intoapache:masterfrom
Conversation
List coders are consistent with equals if underlying element coders are. Allocate objects in structuralValue only if needed.
Map coders are consistent with equals if underlying coders are. Allocate objects in structuralValue only if needed.
kanterov
force-pushed
the
kanterov_structuralValue
branch
from
b324ac1 to
8b4f60e
Compare
Member
|
Wow, I'm actually shocked by this. I thought certainly that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consistentWithEqualsstructruralValueFollow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)