[BEAM-5887] Rollforward "Fix classifier for unshaded tests"#6868
[BEAM-5887] Rollforward "Fix classifier for unshaded tests"#6868kennknowles merged 1 commit intoapache:masterfrom
Conversation
This reverts commit 808a7aa. Rolling forward this fix, which we can test without re-enabling parallel builds.
|
Seed job has re-disabled parallel builds for postcommits, so going to run them against just this fix. This fix also speeds things up for local dev, so has value on its own. |
|
run java postcommit |
|
Also, notably #6864 only re-enable parallel builds for postcommit. That was an oversight on my part. If it had also re-enabled for precommit, it would likely have been caught there. |
|
OK, slightly more thinking and there's this: The failure was a unit test, not an integration test. It is run in both precommit and postcommit, but only postcommit failed. And only postcommit had enabled parallel builds. So I would guess that the classifier fix is OK. |
|
The test that failed was using Mockito argument capture across threads, and explicitly unsupported practice. It seems extremely likely that it was the parallel build that caused that test to start failing. Just another data point in moving forwards with parallel build efforts. |
|
Green including postcommit. Please take a look. |
|
LGTM |
2 participants
Rolling forward this fix, which we can test against postcommit without re-enabling parallel
builds.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)