[BEAM-5915] Timeout http requests, if they got stuck, at dataflow job creation time#6922
Merged
Conversation
Member
Author
|
run python postcommit |
udim
reviewed
Nov 2, 2018
| credentials = get_service_credentials() | ||
|
|
||
| # Use 60 second timeout avoid hangs during network flakiness. | ||
| http_client = httplib2.Http(timeout=60) |
Member
There was a problem hiding this comment.
Could you update the comment to reflect what kind of timeout this is?
I believe it is a timeout at the socket operation level.
Member
Author
There was a problem hiding this comment.
Done. It is the socket timeout (https://github.com/httplib2/httplib2/blob/8b65b523359f0da7e91e130e4877f941cf4511d5/python2/httplib2/__init__.py#L1588)
udim
approved these changes
Nov 6, 2018
Member
Author
|
run python postcommit |
3 tasks
kennknowles
pushed a commit
to kennknowles/beam
that referenced
this pull request
Jul 17, 2019
… creation time (apache#6922) * Timeout http requests, if they got stuck, at dataflow job creation time
kennknowles
pushed a commit
to kennknowles/beam
that referenced
this pull request
Jul 17, 2019
… creation time (apache#6922) * Timeout http requests, if they got stuck, at dataflow job creation time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)