Skip to content

[BEAM-5960] Revert "[BEAM-5817] Add Java only BoundedSideInputJoin benchmark#6932

Merged
kennknowles merged 1 commit intoapache:masterfrom
kennknowles:nexmark-rollback
Nov 3, 2018
Merged

[BEAM-5960] Revert "[BEAM-5817] Add Java only BoundedSideInputJoin benchmark#6932
kennknowles merged 1 commit intoapache:masterfrom
kennknowles:nexmark-rollback

Conversation

@kennknowles
Copy link
Member

This reverts commit a62314e.

The existing Nexmark runs scrape through the enum values and it is
trying to run it before it is ready. Rolling back while I fix it to be an explicit whitelist.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

…tests to Nexmark (not wired up fully)"

This reverts commit a62314e.

The existing Nexmark runs scrape through the enum values and it is
trying to run it before it is ready.
@kennknowles
Copy link
Member Author

run Direct Runner Nexmark Tests

@kennknowles
Copy link
Member Author

Ah, no phrase triggering so we can't confirm signal.

@kennknowles
Copy link
Member Author

Confirmed failure of the SMOKE suite on direct runner on master: https://scans.gradle.com/s/uscfucywf5dsg/
Confirmed succes after this: https://scans.gradle.com/s/xhd6sebzmpgys

@kennknowles
Copy link
Member Author

Because it is a build break rollback, submitting then getting LGTM.

@kennknowles kennknowles merged commit 5c6bfb9 into apache:master Nov 3, 2018
@kennknowles kennknowles deleted the nexmark-rollback branch November 3, 2018 02:55
@jasonkuster
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments