Skip to content

Conversation

@amaliujia
Copy link
Contributor

  1. Fix DATE - INTERVAL
  2. Test DATE +/- INTERVAL.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@amaliujia amaliujia force-pushed the rui_wang-date_add_sub branch from 036b6a0 to 58ca9ff Compare November 6, 2018 23:47
@amaliujia amaliujia force-pushed the rui_wang-date_add_sub branch from 58ca9ff to 96f9115 Compare November 6, 2018 23:49
@amaliujia amaliujia changed the title [BEAM-6001] fix DATE - INTERVAL, test DATE +/- INTERVAL. [BEAM-6001] Fix DATE - INTERVAL and test DATE +/- INTERVAL. Nov 6, 2018
@amaliujia
Copy link
Contributor Author

Copy link
Contributor

@akedin akedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akedin akedin merged commit 3bde7db into apache:master Nov 7, 2018
@amaliujia amaliujia deleted the rui_wang-date_add_sub branch November 7, 2018 00:56
@amaliujia
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants