[BEAM-479] Move local Flink integration tests to a profile#710
[BEAM-479] Move local Flink integration tests to a profile#710kennknowles wants to merge 2 commits intoapache:masterfrom
Conversation
kennknowles
force-pushed
the
remove-flink-local
branch
from
e4897fd to
ab1c736
Compare
|
This should not yet be working, right? |
These tests can now be activated on the commandline with -P local-runnable-on-service-tests and are activated directly by Jenkins.
kennknowles
force-pushed
the
remove-flink-local
branch
from
ab1c736 to
a05b785
Compare
|
Right. Just rebased after the merge of #709 and it is working. And the postcommit has been running successfully all along, and confirmed that it does test all the SDK tests that are pulled in: https://builds.apache.org/view/Beam/job/beam_PostCommit_RunnableOnService_FlinkLocal/org.apache.beam$beam-runners-flink_2.10/6/testReport/ |
|
@manuzhang We just set up a Gearpump postcommit in Jenkins. Now I believe the Gearpump runner configuration should be updated in the same way as this - take a look and replicate? |
|
@kennknowles okay, let me try. |
|
LGTM, but I will wait for Flinkers to LGTM before merging :) |
|
Thanks for the PR @kennknowles! Could you shed some lights on the current testing configuration? As far as I understand, the following tests are configured for the Flink Runner:
Is that correct? |
|
Should we move the config for the streaming tests to the new profile as well? They are deactivated for now but they will be at some (near) point in the future. |
+1 would make sense |
|
OK, I moved the @mxm you are completely correct about the different tests. Those that are activated by a property are run by Jenkins using a local configuration. That could change to a cluster in the future. |
|
Thanks. Looks good to merge to me. |
* feat: Add bloom filter related proto fields PiperOrigin-RevId: 529511263 Source-Link: googleapis/googleapis@b071320 Source-Link: https://github.com/googleapis/googleapis-gen/commit/81dcde708a6e39da0f2f47dc8f16ee5e681a559f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkY2RlNzA4YTZlMzlkYTBmMmY0N2RjOGYxNmVlNWU2ODFhNTU5ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
5 participants
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
These tests are now activated by Jenkins in the intended way, the same as Dataflow, via
mvn -DrunnableOnServicePipelineOptions=...Since a local configuration is convenient and canonical, it is also valuable to have them in the config, so I have put them in a profile where the option string is hardcoded. This can be activated on the with
mvn -P local-runnable-on-service-tests.