[BEAM-6114] Add isBounded() to BeamRelNode and BeamSqlTable, use for JOIN#7121
Merged
kennknowles merged 1 commit intoapache:masterfrom Nov 27, 2018
Merged
[BEAM-6114] Add isBounded() to BeamRelNode and BeamSqlTable, use for JOIN#7121kennknowles merged 1 commit intoapache:masterfrom
kennknowles merged 1 commit intoapache:masterfrom
Conversation
kennknowles
force-pushed
the
sql-isbounded
branch
from
7abb458 to
0e405a8
Compare
kennknowles
force-pushed
the
sql-isbounded
branch
from
0e405a8 to
adf659e
Compare
Member
Author
akedin
reviewed
Nov 27, 2018
| POutput buildIOWriter(PCollection<Row> input); | ||
|
|
||
| /** Whether this table is bounded (known to be finite) or unbounded (may or may not be finite). */ | ||
| PCollection.IsBounded isBounded(); |
Contributor
There was a problem hiding this comment.
I think we probably want to ultimately get rid of BeamSqlTable and just use raw PCollections
Member
Author
There was a problem hiding this comment.
I'm not sure the best way to split up the metadata about a table and its implementation. I believe there might be a different way to organize BeamSqlTable and TableProvider. Good to keep in mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds boundedness information to the SQL/Calcite planner's relational algebra representation and uses it to select a join transform.
This builds on #7118 which separates the lookup join into its own PTransform. In this PR, the non-lookup side input join and "standard" join are also made into separate PTransforms.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)