[BEAM-6011] Docs: Add a paragraph about Nexmark Phrase triggering#7122
Closed
[BEAM-6011] Docs: Add a paragraph about Nexmark Phrase triggering#7122
Conversation
echauchot
requested changes
Nov 22, 2018
Contributor
echauchot
left a comment
echauchot
left a comment
There was a problem hiding this comment.
Hey, I agree with the objective but IMHO this does not belong to a user facing page but more to a dev facing page. @kennknowles just added the user nexmark page to the wiki for devs (see https://cwiki.apache.org/confluence/display/BEAM/Running+Nexmark). I would suggest that you close this PR and simply directly modify the wiki page.
Contributor
Author
|
You are right - I should do the other thing. I was not aware of the nexmark wiki pages. Thanks! |
Contributor
|
Normal, it was a direct discussion with Kenn yesterday ;) not yet public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@echauchot could you take a look (a quick one)?
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)