[BEAM-5197] Sickbay Flink UnboundedSourceWrapperTest.testWatermarkEmission() #7137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c20192. This timeout increase was made to the wrong test method. Further investigation shows that increased timeout does not help, as the issue appears to be a full deadlock.
2 tasks
tweise
approved these changes
Nov 27, 2018
Member
Author
|
The flakes in https://issues.apache.org/jira/browse/BEAM-6130 and https://issues.apache.org/jira/browse/BEAM-6129 struck here. I would prefer not to fix all flakes in one PR, but that would seem the only way to reliable green. I am going to make the call and merge this, moving on to the others separately. |
mxm
reviewed
Nov 27, 2018
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** Tests for {@link UnboundedSourceWrapper}. */ | ||
| @RunWith(Enclosed.class) |
Contributor
There was a problem hiding this comment.
Won't this disable all tests of the nested classes? Was this intended?
Member
Author
There was a problem hiding this comment.
Ah, I could have left this in place. This was a line from my earlier PR. Before that time, this was never there. It turns out that many test runners will find the inner classes anyhow. But I do think this should be restored.
Contributor
|
Thank you for taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sickbays the test until it can be diagnosed, as it is very flaky and increased timeout is not effective.
This also reverts a prior erroneous "fix".
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)