[BEAM-5884] Move the nullable attribute onto FieldType.#7175
Merged
reuvenlax merged 8 commits intoapache:masterfrom Dec 1, 2018
Merged
[BEAM-5884] Move the nullable attribute onto FieldType.#7175reuvenlax merged 8 commits intoapache:masterfrom
reuvenlax merged 8 commits intoapache:masterfrom
Conversation
akedin
approved these changes
Nov 30, 2018
| public abstract TypeName getTypeName(); | ||
|
|
||
| // Whether this type is nullable. | ||
| public abstract Boolean getNullable(); |
Contributor
There was a problem hiding this comment.
I wonder if a convenience method FieldType nullable() { return toBuilder().setNullable(true).build(); } would make sense
Contributor
Author
There was a problem hiding this comment.
@akedin in fact there is such a method, but it's called withNullable
reuvenlax
changed the title
Member
|
This may have caused precommit to time out: https://issues.apache.org/jira/browse/BEAM-6171 |
Contributor
Author
|
Looking
…On Mon, Dec 3, 2018 at 5:25 PM Udi Meiri ***@***.***> wrote:
This may have caused precommit to time out:
https://issues.apache.org/jira/browse/BEAM-6171
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#7175 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUGE1adobQrTxDd7UZevBSz3NPz20CeUks5u1c8dgaJpZM4Y8gJa>
.
|
Contributor
Author
|
Ok appears to be an easy fix. I think SQL is improperly comparing
FieldTypes here.
Since other PRs have been merged that depend on this PR, at this point a
roll-forward fix is probably easier than a rollback.
…On Mon, Dec 3, 2018 at 5:57 PM Reuven Lax ***@***.***> wrote:
Looking
On Mon, Dec 3, 2018 at 5:25 PM Udi Meiri ***@***.***> wrote:
> This may have caused precommit to time out:
> https://issues.apache.org/jira/browse/BEAM-6171
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#7175 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AUGE1adobQrTxDd7UZevBSz3NPz20CeUks5u1c8dgaJpZM4Y8gJa>
> .
>
|
Contributor
Author
|
+ anton and apilloud
SQL is asserting that the PubSub schema looks a certain way, however now
that nullable is part of FieldType the comparison is failing. This should
be a trivial fix, which we can take care of tomorrow.
…On Mon, Dec 3, 2018 at 6:08 PM Reuven Lax ***@***.***> wrote:
Ok appears to be an easy fix. I think SQL is improperly comparing
FieldTypes here.
Since other PRs have been merged that depend on this PR, at this point a
roll-forward fix is probably easier than a rollback.
On Mon, Dec 3, 2018 at 5:57 PM Reuven Lax ***@***.***> wrote:
> Looking
>
> On Mon, Dec 3, 2018 at 5:25 PM Udi Meiri ***@***.***>
> wrote:
>
>> This may have caused precommit to time out:
>> https://issues.apache.org/jira/browse/BEAM-6171
>>
>> —
>> You are receiving this because you modified the open/close state.
>> Reply to this email directly, view it on GitHub
>> <#7175 (comment)>, or mute
>> the thread
>> <https://github.com/notifications/unsubscribe-auth/AUGE1adobQrTxDd7UZevBSz3NPz20CeUks5u1c8dgaJpZM4Y8gJa>
>> .
>>
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.