[BEAM-6367] Fix JdbcDriver breaking DriverManager#getConnection #7417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @apilloud |
`JdbcDriver#getConnection` should return `null` if it doesn't accept provided url.
kanterov
force-pushed
the
kanterov_fix_beam_driver
branch
from
8235b9b to
a1d938e
Compare
Member
|
Oops, good catch. LGTM. |
2 tasks
Member
Author
|
@apilloud thanks for the quick feedback! |
kennknowles
added a commit
that referenced
this pull request
Jan 4, 2019
…10.0: Fix JdbcDriver breaking DriverManager#getConnection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JdbcDriver#getConnectionshould returnnullif it doesn't acceptprovided url.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)