[BEAM-6440] Fix leakage of timer de-duplication map#7530
Merged
mxm merged 1 commit intoapache:release-2.10.0from Jan 16, 2019
Merged
[BEAM-6440] Fix leakage of timer de-duplication map#7530mxm merged 1 commit intoapache:release-2.10.0from
mxm merged 1 commit intoapache:release-2.10.0from
Conversation
The FlinkStateInternals use a keyed map of pending timers to make up for Flink's limitation to only be able to delete timers with their original timestamp, not via timer id. The Map leaked memory because subclasses of DoFnOperator overwrote `fireTimer` which was responsible for performing cleanup in the map upon firing a timer.
kennknowles
approved these changes
Jan 16, 2019
Member
|
Looks like trouble in the precommits |
Contributor
|
FYI This is backported from #7517. |
Contributor
|
Run Python PreCommit |
Contributor
|
Run Python_ValidatesRunner_Flink PreCommit |
Contributor
|
Run Python Flink ValidatesRunner |
Contributor
|
Above failing PreCommit Python_ValidatesRunner_Flink has been temporarily removed: #7533 |
mxm
approved these changes
Jan 16, 2019
Contributor
|
Python PreCommit fails but is unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FlinkStateInternals use a keyed map of pending timers to make up for Flink's
limitation to only be able to delete timers with their original timestamp, not
via timer id.
The Map leaked memory because subclasses of DoFnOperator overwrote
fireTimerwhich was responsible for performing cleanup in the map upon firing a timer.
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)