[BEAM-6539] Revert "Merge pull request #7316 [BEAM-6269] Cross-SDK transform expa… #7663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Run Java PortabilityApi PostCommit |
Contributor
Author
|
Run Dataflow PortabilityApi ValidatesRunner |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Python_PVR_Flink PreCommit |
Contributor
Author
|
Run Dataflow PortabilityApi ValidatesRunner |
Contributor
Author
|
Since both of you reviewed the original PR. One PostCommit (Portable Dataflow ValidatesRunner) is still running as I'm writing this, but the other one (Portable Java PostCommit) seems to be fixed by this revert, so I'm expecting the unfinished one to also be fixed since it was exhibiting the same error. |
Member
|
LGTM. All the postcommits are green. |
Contributor
|
Looks like all post-submits passed with this reverted. So I'll go ahead and submit this revert cc: @robertwb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsion protocol."
This reverts commit 26bd104, reversing
changes made to dcda09a.
This is causing issues in some portable Java PostCommits: https://issues.apache.org/jira/browse/BEAM-6539
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)