Skip to content

[BEAM-6426] Enforce ban of non-vendored Guava, with exceptions #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iemejia merged 1 commit into from
Feb 1, 2019
Merged

[BEAM-6426] Enforce ban of non-vendored Guava, with exceptions #7695

iemejia merged 1 commit into from
Feb 1, 2019

Conversation

@iemejia
Copy link
Member

@iemejia iemejia commented Feb 1, 2019

@iemejia iemejia requested a review from kennknowles February 1, 2019 00:07
@kennknowles
Copy link
Member

kennknowles commented Feb 1, 2019

Does the illegal import checkstyle not work?

@kennknowles
Copy link
Member

kennknowles commented Feb 1, 2019

LGTM either way. Having this in place is good.

@iemejia
Copy link
Member Author

iemejia commented Feb 1, 2019

I preferred the per line parsing to avoid users (and IDE completion in particular) from using the fully qualified naming e.g. com.google.common.cache.CacheBuilder instead of the vendored one even if this is most costly (computationally). Notice that there were already some use cases like that that were not cached before in the same PR.

@iemejia iemejia merged commit a87b2db into apache:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennknowles kennknowles Awaiting requested review from kennknowles

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iemejia @kennknowles