Skip to content

Conversation

@kennknowles
Copy link
Member

A few reasons for this:

  • simpler to just read it, as a user
  • SQL docs should be uncoupled as possible from Javadocs
  • there's plenty of formats that are actually not such a big deal to list
  • there was a 404 because the javadoc for CSVFormat was down.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@kennknowles kennknowles requested review from akedin and melap February 1, 2019 00:50
@akedin akedin merged commit af6b869 into apache:master Feb 1, 2019
@akedin
Copy link
Contributor

akedin commented Feb 1, 2019

LGTM, yes

swegner added a commit that referenced this pull request Feb 2, 2019
@kennknowles kennknowles deleted the CSVFormat branch January 4, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants