Skip to content

Conversation

@Mikhail-Ivanov
Copy link
Contributor

Fixed archetype-starter build script and provided an appropriate unit tests in accordance with: BEAM-5328

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@kennknowles kennknowles requested a review from lukecwik March 5, 2019 17:41
Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To finish BEAM-5328, you also want to ensure that your test runs via Jenkins similar to how the quickstart tests are currently running. To do this you'll need to:

  1. make a task which is capable of executing this StarterArchetype like:

    project.ext.createJavaExamplesArchetypeValidationTask = {

  2. add your task to the runJavaExamplesValidationTask:

    task runJavaExamplesValidationTask {

(optional) As another follow-up, it would be nice to rename runJavaExamplesValidationTask to not be "examples" specific but something like runJavaPostReleaseTests. Might want to get an opinion from @alanmyrvold as to the name.

I'll merge this as is once the tests are green and allow you to open up follow-up PRs.

@lukecwik
Copy link
Member

lukecwik commented Apr 8, 2019

retest this please

@lukecwik lukecwik merged commit a142470 into apache:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants