-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-6720] Add binary compatibility adapters for ProcessFunction/InferableFunction overloads #7911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
23dec86 to
208aa9a
Compare
|
#7160 also changed the signatures of TypeDescriptors.inputOf and .outputOf. Would they also need adapters? |
77f6ae5 to
69ea20e
Compare
|
OK, added the next couple adapters and eliminated use of rawtypes. |
|
Run Java_Examples_Dataflow PreCommit" |
|
There is a compiler warning failing the build: (on Java PreCommit) 15:06:33 > Task :beam-sdks-java-extensions-euphoria:compileJava FAILED Is this because the Deprecated annotation? |
|
Run Java_Examples_Dataflow PreCommit |
|
This use (https://github.com/apache/beam/blob/master/sdks/java/extensions/euphoria/src/main/java/org/apache/beam/sdk/extensions/euphoria/core/translate/ReduceByKeyTranslator.java#L143) of SimpleFunction need to be changed to use ProcessFunction. |
|
I should remove the deprecation, because overloading will prefer the more specific class. |
OK. I think we can still update the euphoria code (not in this PR). Let me know if I can help here. |
612a008 to
7284279
Compare
…erableFunction overloads
7284279 to
584bbec
Compare
|
The error looks like a flake, re-running the test just in case. |
|
Run Java PreCommit |
Because method overloads are resolved statically, 2.10.0 is compile compatible but not binary compatible with 2.9.0.
This introduces adapters where needed to restore binary compatibility.
Testing will be by hand and one-off as I'm not sure the infrastructure that would be needed to test these automatically.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.