Skip to content

Conversation

@alanmyrvold
Copy link
Member

Fix ./gradlew :beam-test-tools:goTest by fixing the package path in build.gradle.

R: @lostluck


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lostluck
Copy link
Contributor

LGTM
If there's a JIRA we can attach to this for the related snapshot issue that would be great. @kennknowles pointed me to the issue, so he may have a suggestion.

To be clear about what's happening here: gogradle uses the package path for building and testing and managing the cleanup state. GoGradle uses that to configure what to unit test in the goTest dependency. The path given didn't exist, but the replacement does, allowing the dependency to pass properly.

It may be possible to reduce/clean up the cancelStaleDataflowJobs task since goGradle should be handling the vendoring properly now, but that's reasonable to defer until I learn how to work with GoGradle properly and see if it needs excising.

@alanmyrvold alanmyrvold changed the title Fix ./gradlew :beam-test-tools:goTest [BEAM-6927] Fix ./gradlew :beam-test-tools:goTest Mar 27, 2019
@alanmyrvold
Copy link
Member Author

Kenn was not aware of a Jira, and I could not find one when searching. Filed https://issues.apache.org/jira/browse/BEAM-6927

@lostluck
Copy link
Contributor

R: @kennknowles Please merge! Thanks!

@apilloud
Copy link
Member

LGTM.

@apilloud apilloud merged commit 352a3d9 into apache:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants