Skip to content

[BEAM-6904] Add tests for structuralValue implementation in coders #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexKbit wants to merge 1 commit into from
Closed

[BEAM-6904] Add tests for structuralValue implementation in coders #8208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BigDecimalCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (BigDecimal value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (BigDecimal value1 : TEST_VALUES) {
for (BigDecimal value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, new BigDecimal(value1.intValue()), new BigDecimal(value2.intValue()));
}
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BigEndianIntegerCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Integer value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Integer value1 : TEST_VALUES) {
for (Integer value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Integer.valueOf(value1), Integer.valueOf(value2));
}
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BigEndianLongCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Long value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Long value1 : TEST_VALUES) {
for (Long value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Long.valueOf(value1), Long.valueOf(value2));
}
}
}
}
19 changes: 19 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BigIntegerCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,23 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (BigInteger value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (BigInteger value1 : TEST_VALUES) {
for (BigInteger value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER,
BigInteger.valueOf(value1.longValue()),
BigInteger.valueOf(value2.longValue()));
}
}
}
}
7 changes: 7 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BitSetCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,11 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (BitSet value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}
}
21 changes: 21 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BooleanCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

import static org.junit.Assert.assertEquals;

import org.apache.beam.sdk.testing.CoderProperties;
import org.apache.beam.vendor.guava.v20_0.com.google.common.collect.ImmutableList;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand All @@ -28,10 +30,29 @@
public class BooleanCoderTest {
private static final Coder<Boolean> TEST_CODER = BooleanCoder.of();

private static final ImmutableList<Boolean> TEST_VALUES =
ImmutableList.of(Boolean.TRUE, Boolean.FALSE);

@Test
public void testStructuralValueReturnTheSameValue() {
Boolean expected = Boolean.TRUE;
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Boolean value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Boolean value1 : TEST_VALUES) {
for (Boolean value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(TEST_CODER, value1, value2);
}
}
}
}
7 changes: 7 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/ByteArrayCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,11 @@ public void encodeNullThrowsCoderException() throws Exception {
public void testEncodedTypeDescriptor() throws Exception {
assertThat(TEST_CODER.getEncodedTypeDescriptor(), equalTo(TypeDescriptor.of(byte[].class)));
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (byte[] value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/ByteCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Byte value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Byte value1 : TEST_VALUES) {
for (Byte value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Byte.valueOf(value1.byteValue()), Byte.valueOf(value2.byteValue()));
}
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/DoubleCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Double value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Double value1 : TEST_VALUES) {
for (Double value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Double.valueOf(value1), Double.valueOf(value2));
}
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/DurationCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (ReadableDuration value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (ReadableDuration value1 : TEST_VALUES) {
for (ReadableDuration value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Duration.millis(value1.getMillis()), Duration.millis(value2.getMillis()));
}
}
}
}
23 changes: 23 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/FloatCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@

import static org.junit.Assert.assertEquals;

import java.util.Arrays;
import java.util.List;
import org.apache.beam.sdk.testing.CoderProperties;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand All @@ -29,10 +32,30 @@ public class FloatCoderTest {

private static final Coder<Float> TEST_CODER = FloatCoder.of();

private static final List<Float> TEST_VALUES =
Arrays.asList(0.0f - 0.5f, 0.5f, 0.3f, -0.3f, 1.0f, Float.MAX_VALUE, Float.MIN_VALUE);

@Test
public void testStructuralValueReturnTheSameValue() {
Float expected = 23.45F;
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Float value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Float value1 : TEST_VALUES) {
for (Float value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Float.valueOf(value1), Float.valueOf(value2));
}
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/InstantCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Instant value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Instant value1 : TEST_VALUES) {
for (Instant value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, new Instant(value1.getMillis()), new Instant(value2.getMillis()));
}
}
}
}
23 changes: 23 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/RowCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,4 +246,27 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = rowCoder.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
Schema schema = Schema.builder().addField("field", FieldType.INT32).build();
Row row = Row.withSchema(schema).addValue(2123).build();
Coder<Row> rowCoder = RowCoder.of(schema);
CoderProperties.structuralValueDecodeEncodeEqual(rowCoder, row);
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
Schema schema = Schema.builder().addField("field", FieldType.INT32).build();
List<Row> rows =
Arrays.asList(
Row.withSchema(schema).addValue(2123).build(),
Row.withSchema(schema).addValue(4534).build());
Coder<Row> rowCoder = RowCoder.of(schema);
for (Row value1 : rows) {
for (Row value2 : rows) {
CoderProperties.structuralValueConsistentWithEquals(rowCoder, value1, value2);
}
}
}
}
19 changes: 19 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/SerializableCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,4 +368,23 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = coder.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
Coder<MyRecord> coder = SerializableCoder.of(MyRecord.class);
MyRecord record = new MyRecord("serTest");
CoderProperties.structuralValueDecodeEncodeEqual(coder, record);
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
List<MyRecord> records =
Arrays.asList(new MyRecord("test1"), new MyRecord("test2"), new MyRecord("test3"));
Coder<MyRecord> coder = SerializableCoder.of(MyRecord.class);
for (MyRecord value1 : records) {
for (MyRecord value2 : records) {
CoderProperties.structuralValueConsistentWithEquals(coder, value1, value2);
}
}
}
}
16 changes: 16 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/StringUtf8CoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,20 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (String value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (String value1 : TEST_VALUES) {
for (String value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(TEST_CODER, value1, value2);
}
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/VarIntCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Integer value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Integer value1 : TEST_VALUES) {
for (Integer value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Integer.valueOf(value1), Integer.valueOf(value2));
}
}
}
}
17 changes: 17 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/coders/VarLongCoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,21 @@ public void testStructuralValueReturnTheSameValue() {
Object actual = TEST_CODER.structuralValue(expected);
assertEquals(expected, actual);
}

@Test
public void testStructuralValueDecodeEncodeEqual() throws Exception {
for (Long value : TEST_VALUES) {
CoderProperties.structuralValueDecodeEncodeEqual(TEST_CODER, value);
}
}

@Test
public void testStructuralValueConsistentWithEquals() throws Exception {
for (Long value1 : TEST_VALUES) {
for (Long value2 : TEST_VALUES) {
CoderProperties.structuralValueConsistentWithEquals(
TEST_CODER, Long.valueOf(value1), Long.valueOf(value2));
}
}
}
}