[BEAM-2220, BEAM-6519] Clean-up package namespace underneath org.apache.beam.sdk.util to be underneath GCP namespace. #8217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….util to be underneath org.apache.beam.sdk.gcp.extensions.util namespace. Since the Dataflow worker has been externalized, this is no longer extremely painful because all the code is in a single repo. This keeps the 'util' package so that we can continue to make backwards incompatible changes to these internal utilities.
Member
Author
|
R: @kennknowles |
kennknowles
approved these changes
Apr 3, 2019
Contributor
|
Does this also fix https://issues.apache.org/jira/projects/BEAM/issues/BEAM-6519 ? |
lukecwik
changed the title
Member
Author
|
@adude3141 Yes, it seems to fix the one and only occurrence that Romain pointed out. |
Member
Author
|
Run Python PreCommit |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Dataflow worker has been externalized, this is no longer extremely painful because all the code is in a single repo.
I kept the 'util' package so we could maintain the lack of backwards compatiblity support for these internal utils.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.