[BEAM-7008] adding UTF8 String coder to Java SDK ModelCoders #8228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwb
requested changes
Apr 4, 2019
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
I don't think we can change the existing coders (in particular, the unnested context) for backwards compatibility reasons.
Contributor
|
FYI, the current implementation uses https://github.com/apache/beam/blob/release-2.12.0/sdks/python/apache_beam/coders/coder_impl.py#L199 to prefix with the length iff the context is nested. |
Contributor
Author
|
retest this please |
robertwb
reviewed
Apr 8, 2019
ihji
force-pushed
the
BEAM-7008
branch
4 times, most recently
from
514a2cf to
3c32587
Compare
ihji
changed the title
3 tasks
ihji
force-pushed
the
BEAM-7008
branch
2 times, most recently
from
a884ccb to
99d5302
Compare
Contributor
Author
3 tasks
ihji
force-pushed
the
BEAM-7008
branch
2 times, most recently
from
77f39c0 to
7bb7d29
Compare
Contributor
|
Let me know when this is ready for me to take another look. |
Contributor
Author
|
run java precommit |
Contributor
Author
|
@robertwb PTAL. Thanks! |
robertwb
approved these changes
May 6, 2019
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
Thanks. This looks good.
(It is unfortunate how many changes are needed just to make something into a standard coder in Java...)
Contributor
|
Thanks @ihji! |
mxm
added a commit
to mxm/beam
that referenced
this pull request
May 8, 2019
With apache#8383 we added support for TestStream in the legacy streaming Flink Runner. This ports TestStream also to the streaming portable Flink Runner. For this to work properly we had to make StringUtf8Coder a standard coder; this was done in apache#8228.
3 tasks
Contributor
|
Run Java PortabilityApi PostCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make StringUtf8Coder standard in Java SDK.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.