Revert "Merge pull request #8228: [BEAM-7008] adding UTF8 String code… #8544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Run Java PortabilityApi PostCommit |
Contributor
Author
|
Run Python PostCommit |
Contributor
Author
|
Run Dataflow PortabilityApi ValidatesRunner |
Contributor
Author
Contributor
|
LGTM. Reopened: https://issues.apache.org/jira/browse/BEAM-7271 |
Contributor
Author
|
Thanks @ihji |
Contributor
Contributor
|
I had no idea this was reverted. Btw, reverting this breaks the Flink ValidatesRunner tests. Please include all parties involved with the original PR when doing a revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r to Java SDK ModelCoders"
This reverts commit 0edab50, reversing
changes made to e7f7399.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.