[BEAM-7406] Include slf4j-jdk14 in Dataflow worker uber jar #8668
Conversation
| // Each included dependency should have a matching relocation rule below that ensures | ||
| // that the shaded jar is correctly built. | ||
|
|
||
| dependencies { |
There was a problem hiding this comment.
This will fail the shadowJarValidationExcludes defined above.
|
The |
lukecwik
left a comment
lukecwik
left a comment
There was a problem hiding this comment.
Could you also add a test that ensures that slf4j-jdk14 is always included in the uber jar. The logic would be quite similar to the validateShadowJar task defined here
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
I added the test you suggested and confirmed that without the runtime dependency it fails.
| // Each included dependency should have a matching relocation rule below that ensures | ||
| // that the shaded jar is correctly built. | ||
|
|
||
| dependencies { |
| shadowTest library.java.mockito_core | ||
| } | ||
|
|
||
| project.task('validateShadedJarContainsSlf4jJdk14', dependsOn: 'shadowJar') { |
2 participants
There is no logging by default since 2.10.0
I don't totally understand why, but the
:workershadow jar already contains the JDK14 adapter while the:legacy-workerdoes not. I did check that this fixes the jar but have not run a job - I will let Jenkins do that work.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.