Skip to content

[BEAM-7766] Default to PiplelineState.UNKNOWN when job state received via v1beta3 cannot be recognized. #9094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltay merged 2 commits into from
Jul 22, 2019
Merged

[BEAM-7766] Default to PiplelineState.UNKNOWN when job state received via v1beta3 cannot be recognized. #9094

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6f43f1
Default to PiplelineState.UNKNOWN when job state returned from v1beta…
tvalentyn Jul 18, 2019
7b9b7bf
fixup: Address review feedback.
tvalentyn Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,9 +1267,9 @@ def has_job(self):
def _get_job_state(self):
values_enum = dataflow_api.Job.CurrentStateValueValuesEnum

# TODO: Move this table to a another location.
# Ordered by the enum values.
api_jobstate_map = {
# Ordered by the enum values. Values that may be introduced in
# future versions of Dataflow API are considered UNKNOWN by the SDK.
api_jobstate_map = defaultdict(lambda: PipelineState.UNKNOWN, {
values_enum.JOB_STATE_UNKNOWN: PipelineState.UNKNOWN,
values_enum.JOB_STATE_STOPPED: PipelineState.STOPPED,
values_enum.JOB_STATE_RUNNING: PipelineState.RUNNING,
Expand All @@ -1281,7 +1281,7 @@ def _get_job_state(self):
values_enum.JOB_STATE_DRAINED: PipelineState.DRAINED,
values_enum.JOB_STATE_PENDING: PipelineState.PENDING,
values_enum.JOB_STATE_CANCELLING: PipelineState.CANCELLING,
}
})

return (api_jobstate_map[self._job.currentState] if self._job.currentState
else PipelineState.UNKNOWN)
Expand Down