[BEAM-7766] Default to PiplelineState.UNKNOWN when job state received via v1beta3 cannot be recognized. #9094
Conversation
|
R: @aaltay |
|
@kennknowles I'd like to fix this on 2.7.1 and can prepare a cherry-pick once this is merged. I set 2.7.1 as fix version on BEAM-7766. |
aaltay
left a comment
aaltay
left a comment
There was a problem hiding this comment.
Could you add a comment there about why we need this?
tvalentyn
force-pushed
the
default_to_unknown
branch
from
1d7376e to
6af0c3c
Compare
…3 cannot be recogninzed.
tvalentyn
force-pushed
the
default_to_unknown
branch
from
6af0c3c to
22f55f1
Compare
tvalentyn
force-pushed
the
default_to_unknown
branch
from
22f55f1 to
7b9b7bf
Compare
|
PTAL. Feel free to update the comment message as you see fit or squash&merge if it looks good to you. Thank you. |
|
I will merge after tests pass. |
|
Ah, I thought I had commented but I do not see my comment. We have had issue with the confusion between "unknown" as a default versus "unknown" as an explicit value returned. What you have done is make the Python SDK match the Java SDK, but I would very much like to separate these two statuses in both SDKs. It masks bugs to have a default that looks like a legitimate path. |
|
It looks like you commented on the JIRA: https://issues.apache.org/jira/browse/BEAM-7766 |
|
Let's continue the discussion on BEAM-7766. |
3 participants
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.