Skip to content

Conversation

@amaliujia
Copy link
Contributor

@amaliujia amaliujia commented Aug 13, 2019


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@amaliujia
Copy link
Contributor Author

amaliujia commented Aug 13, 2019

R: @kennknowles @lukecwik

I will hold this PR unitl receive more feedback [1]. This PR is used to see what's the first step to kick off retraction effort. Also it's interesting to know what's the process of adding something to model proto.

[1] : https://lists.apache.org/thread.html/689dd70669660fb60944557e039c18b24148d8a2caf068bf5f07b1dc@%3Cdev.beam.apache.org%3E

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to regenerate the go protos following https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/model/PROTOBUF.md

@amaliujia
Copy link
Contributor Author

Thanks Luke for your pointer!

also R: @lostluck as this change affects Go SDK

@amaliujia
Copy link
Contributor Author

I think the failed go check is due to new generated proto for Go used 3.x protobuf while current Go SDK uses 2.x protobuf.

I will wait Bobert's feedback on what's the best way to go (upgrade or stay with 2.x).

@amaliujia amaliujia force-pushed the add_retraction_in_java_sdk branch from 8dced31 to 530f1d7 Compare August 13, 2019 21:55
@lukecwik
Copy link
Member

I'm pretty sure that Go is using proto 3 and not proto 2

@amaliujia
Copy link
Contributor Author

Thanks Luke. I also realized that proto files in model are proto3 already.

Undo re-generated protos for Go.

Thanks Daniel for creating JIRA to track re-generate Go protos in correct version: https://jira.apache.org/jira/browse/BEAM-7970.

I think we can separate this PR's change with re-generation of protos for Go, given the created JIRA to track proto re-generation effort. I will also wait for @lostluck to see if he is also ok on this separation.

@lukecwik lukecwik merged commit 544604c into apache:master Aug 16, 2019
@amaliujia amaliujia deleted the add_retraction_in_java_sdk branch August 19, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants