-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-7965] add retracting mode to model proto #9329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will hold this PR unitl receive more feedback [1]. This PR is used to see what's the first step to kick off retraction effort. Also it's interesting to know what's the process of adding something to model proto. |
lukecwik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to regenerate the go protos following https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/model/PROTOBUF.md
|
Thanks Luke for your pointer! also R: @lostluck as this change affects Go SDK |
|
I think the failed go check is due to new generated proto for Go used 3.x protobuf while current Go SDK uses 2.x protobuf. I will wait Bobert's feedback on what's the best way to go (upgrade or stay with 2.x). |
8dced31 to
530f1d7
Compare
|
I'm pretty sure that Go is using proto 3 and not proto 2 |
|
Thanks Luke. I also realized that proto files in Undo re-generated protos for Go. Thanks Daniel for creating JIRA to track re-generate Go protos in correct version: https://jira.apache.org/jira/browse/BEAM-7970. I think we can separate this PR's change with re-generation of protos for Go, given the created JIRA to track proto re-generation effort. I will also wait for @lostluck to see if he is also ok on this separation. |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.