[BEAM-8354] Add RowJsonSerializer#9732
Merged
kennknowles merged 1 commit intoapache:masterfrom Oct 7, 2019
Merged
Conversation
kennknowles
approved these changes
Oct 7, 2019
Member
kennknowles
left a comment
There was a problem hiding this comment.
This looks good. There's a Java tradition (which we don't follow all the time) of putting all tests for Foo in FooTest. It might make sense to consolidate the deserializer and serializer into an aggregating class just to make this more "normal".
Member
Author
|
I like the idea of combining serializer and seserializer into an outer class. Would there be any concern with changing the API since |
Member
|
Ah, everything in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
RowJsonSerializer, and renamesRowJsonDeserializerTesttoRowJsonTest, as it now includes roundtrip tests from row to json and back.R: @apilloud
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.