[BEAM-8532] Output timestamp should be the inclusive, not exclusive, end of window.#9958
Merged
robertwb merged 1 commit intoapache:masterfrom Nov 4, 2019
Merged
Conversation
robertwb
force-pushed
the
trigger-timestamp
branch
from
3a3a40e to
4b98c87
Compare
robertwb
force-pushed
the
trigger-timestamp
branch
from
4b98c87 to
4b107d2
Compare
kennknowles
approved these changes
Nov 2, 2019
Member
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
Wow! This seems valuable enough to cherrypick to 2.17.0 release branch, even though it is not a regression.
Contributor
Author
|
Yeah, amazing (and scary) what you can find when you add some testing. |
Contributor
Author
|
Yes, I agree it's severe enough to consider cherry-picking into 2.17. @Ardagan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.