[BEAM-8504] Fix a bug related to zero-row responses#9987
Merged
chamikaramj merged 1 commit intoapache:masterfrom Nov 5, 2019
Merged
[BEAM-8504] Fix a bug related to zero-row responses#9987chamikaramj merged 1 commit intoapache:masterfrom
chamikaramj merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
chamikaramj
reviewed
Nov 4, 2019
Contributor
There was a problem hiding this comment.
Seems like message does not match with the condition ? Do you just want to make sure that the row count is not negative for some reason ?
Contributor
Author
There was a problem hiding this comment.
And this is why we do code reviews! Done.
Contributor
There was a problem hiding this comment.
Probably re-word to "Fraction consumed from the current response has to be larger than or equal to the fraction consumed from the previous response. But received %s and %s respectively."
In some rare cases, the server can included zero rows in the response messages, leading to a zero count of rows and a progress report that does not increase. This change relaxes some of our preconditions.
Contributor
|
LGTM. Thanks. |
Member
|
Thanks. It looks good! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some rare cases, the server can included zero rows in the response messages,
leading to a zero count of rows and a progress report that does not
increase. This change relaxes some of our preconditions.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.